Re: [Xen-devel] [PATCH 1/2] x86/hvm: actually release ioreq server pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.04.15 at 17:46, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -496,7 +496,7 @@ static void hvm_free_ioreq_gmfn(struct domain *d, 
> unsigned long gmfn)
>  {
>      unsigned int i = gmfn - d->arch.hvm_domain.ioreq_gmfn.base;
>  
> -    clear_bit(i, &d->arch.hvm_domain.ioreq_gmfn.mask);
> +    set_bit(i, &d->arch.hvm_domain.ioreq_gmfn.mask);
>  }

Double checking this I came to wonder whether
HVM_PARAM_NR_IOREQ_SERVER_PAGES handling isn't broken
when invoked a second time with a.value smaller than what was
used the first time, or when any server pages are already in
use.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel