Re: [Xen-devel] [PATCH v4 3/3] xentrace: Implement cpu mask range parsing of human values (-c).

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 04/23/2015 02:31 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Apr 15, 2015 at 01:26:45PM +0100, Ian Campbell wrote:
>> On Fri, 2015-04-03 at 20:43 -0400, Konrad Rzeszutek Wilk wrote:
>>> Instead of just using -c 0x<some hex value> we can
>>> also use: -c <starting cpu>-<end cpu>, -c <cpu1>,<cpu2>, or a
>>> combination of them, or 'all' for all cpus.
>>>
>>> This new format can include just singular CPUs: -c <cpu1>,
>>> or ranges without an start or end (and xentrace will figure out
>>> the values), such as: -c -<cpu2> (which will include cpu0, cpu1,
>>> and cpu2) or -c <cpu2>- (which will include cpu2 and up to MAX_CPUS).
>>>
>>> That should make it easier to trace the right CPU if
>>> using this along with 'xl vcpu-list'.
>>>
>>> The code has been lifted from the Linux kernel, see file
>>> lib/bitmap.c, function __bitmap_parselist.
>>>
>>> To make the old behavior and the new function work, we check
>>> to see if the arguments have '0x' in them. If they do
>>> we use the old style parsing (limited to 32 CPUs). If that
>>> does not exist we use the new parsing.
>>>
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>> ---
>>> [v4: Fix per George's review]
>>> [v5: Redo per George's review]
>>
>> I'll leave final word on this one to George.
> 
> OK.
> 
> George, I just reposted this one under v4.1 without any changes
> (see http://lists.xen.org/archives/html/xen-devel/2015-04/msg02702.html).
> 
> Please review this one or the other one.

I had *just* downloaded and started to look at that patch.  At least you
caught me early. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel