[Xen-devel] [PATCH v4.1] Support CPU list parsing in xentrace.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

Hey George, Ian,


Ian: I copied your comment and stuffed it in, please Ack:
 [PATCH v4.1 1/3] libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu,

already Acked:
 [PATCH v4.1 2/3] libxc/xentrace: Use xc_cpumap_t for

George: please review (it is unchanged since v4 posting):
 [PATCH v4.1 3/3] xentrace: Implement cpu mask range parsing of human


Since v4 [http://lists.xen.org/archives/html/xen-devel/2015-04/msg00441.html]:
 - Lifted comment from Ian about xc_cpumap.
 - Added Ian's Ack on one patch.

Since v3 [http://lists.xen.org/archives/html/xen-devel/2015-03/msg02986.html]:
 - Rebased code on George's patch.
 - Added support for 'all' in CPU parsing.

In v2 [http://lists.xen.org/archives/html/xen-devel/2014-06/msg01835.html]:
 - Redid the code per George's feedback.
 - Expanded the xc_cpumap_* calls so that we have an 'setbit' variant.


The purpose of these patches is to allow users of xentrace to narrow
down a specific CPU without having to figure out a bit mask. They
fix the limitation of the bit mask which is it can only do up to 32-bits
- which on large machines (say 120CPUs), you can't selectively trace anything
past 32CPUs.

The code expands the -c parameter where you can do -c <starting cpu>-<end cpu>,
or -c <cpu1>,<cpu2>, or a combination of them, or "all". There is also the mode 
of
automatic detection, such as: -c -,<cpu2> (so it will assume up to cpu2 - so
0,1, and 2 CPU), or the inverse: -c <cpu2>- (which will figure the max cpus and
do it from cpu2 up to maximum cpu).

This along with 'xl vcpu-list' makes it extremely easy to trace a specific
guest (if pinned).

You can still use the -c 0x<some hex value> option if you prefer.

The patches are also at my git tree:

 git://xenbits.xen.org/people/konradwilk/xen.git xentrace.v4.1



 tools/libxc/include/xenctrl.h |  11 ++-
 tools/libxc/xc_misc.c         |  26 ++++++
 tools/libxc/xc_tbuf.c         |  33 +++++--
 tools/xentrace/xentrace.8     |  34 ++++++-
 tools/xentrace/xentrace.c     | 212 ++++++++++++++++++++++++++++++++++++++----
 5 files changed, 285 insertions(+), 31 deletions(-)

George Dunlap (1):
      libxc/xentrace: Use xc_cpumap_t for xc_tbuf_set_cpu_mask

Konrad Rzeszutek Wilk (2):
      libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu, testcpu] to complement 
xc_cpumap_alloc.
      xentrace: Implement cpu mask range parsing of human values (-c).


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel