Re: [Xen-devel] [RFC PATCH COLO v5 07/29] support to resume uncooperative HVM guests

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote:
> From: Wen Congyang <wency@xxxxxxxxxxxxxx>
> 
> For PVHVM, the hypercall return code is 0, and it can be resumed
> in a new domain context.
> 
> For HVM, do nothing.
> 
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> ---
>  tools/libxc/xc_resume.c | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxc/xc_resume.c b/tools/libxc/xc_resume.c
> index e67bebd..b862ce3 100644
> --- a/tools/libxc/xc_resume.c
> +++ b/tools/libxc/xc_resume.c
> @@ -109,6 +109,21 @@ static int xc_domain_resume_cooperative(xc_interface 
> *xch, uint32_t domid)
>      return do_domctl(xch, &domctl);
>  }
>  
> +static int xc_domain_resume_hvm(xc_interface *xch, uint32_t domid)
> +{
> +    DECLARE_DOMCTL;
> +
> +    /*
> +     * If it is PVHVM, the hypercall return code is 0, and resume
> +     * it in a new domain context.

What is a "new domain context"?

> +     *
> +     * If it is a HVM, do nothing.

If it is an HVM guest they you do something, you call a hypercall.

If that hypercall is somehow a NOP for an HVM domain then I think that
needs to be explained somewhere here.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel