[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()
- To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
- From: Doug Ledford <dledford@xxxxxxxxxx>
- Date: Wed, 22 Apr 2015 09:54:38 -0400
- Cc: linux-fbdev@xxxxxxxxxxxxxxx, mst@xxxxxxxxxx, Daniel Vetter <daniel.vetter@xxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, jbeulich@xxxxxxxx, sean.hefty@xxxxxxxxx, cocci@xxxxxxxxxxxxxxx, ville.syrjala@xxxxxxxxxxxxxxx, roland@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, Roland Dreier <roland@xxxxxxxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>, Suresh Siddha <sbsiddha@xxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, hal.rosenstock@xxxxxxxxx, Antonino Daplas <adaplas@xxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxx>, Stefan Bader <stefan.bader@xxxxxxxxxxxxx>, infinipath@xxxxxxxxx, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, luto@xxxxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 22 Apr 2015 14:04:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
> + /* MTRR was used if this is non-zero */
> + if (!dd->wc_cookie)
> vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
And this:
> + dd->wc_cookie = arch_phys_wc_add(pioaddr, piolen);
> + if (dd->wc_cookie < 0)
> + ret = -EINVAL;
don't agree on what wc_cookie will be on error.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
