Re: [Xen-devel] [PATCH 4/5] raisin: introduce ovmf

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 04/21/2015 04:43 PM, Stefano Stabellini wrote:
> On Tue, 21 Apr 2015, George Dunlap wrote:
>> On 04/21/2015 03:55 PM, Stefano Stabellini wrote:
>>> diff --git a/components/series b/components/series
>>> index f0f3cfa..fe9092a 100644
>>> --- a/components/series
>>> +++ b/components/series
>>> @@ -1,4 +1,5 @@
>>>  seabios
>>> +ovmf
>>>  xen
>>>  qemu
>>>  qemu_traditional
>>> diff --git a/components/xen b/components/xen
>>> index b3426f0..b3a0c96 100644
>>> --- a/components/xen
>>> +++ b/components/xen
>>> @@ -29,7 +29,8 @@ function xen_build() {
>>>      cd xen-dir
>>>      ./configure --prefix=$PREFIX 
>>> --with-system-qemu=$PREFIX/lib/xen/bin/qemu-system-i386 \
>>>          --disable-qemu-traditional --enable-rombios \
>>> -        --with-system-seabios="$BASEDIR"/seabios-dir/out/bios.bin
>>> +        --with-system-seabios="$BASEDIR"/seabios-dir/out/bios.bin \
>>> +        --with-system-ovmf="$BASEDIR"/ovmf-dir/ovmf.bin
>>
>> Does this still work if you don't build ovmf?
> 
> No, it doesn not and it is the same issue with seabios.
> I should probably add a patch to check on components before adding these
> command line options.

Maybe you want to check the existence of the binary you're pointing to?
 That way if someone does 'COMPONENTS="xen" ./raise build', it won't
think that you've decided not to build ovmf (or seabios).

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel