Re: [Xen-devel] [PATCH 6/7] docs/build: Move install checks into individual build targets

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-04-21 at 15:18 +0100, Jan Beulich wrote:
> >>> On 21.04.15 at 16:15, <ian.campbell@xxxxxxxxxx> wrote:
> > On Mon, 2015-04-20 at 13:01 +0100, Andrew Cooper wrote:
> >> On 20/04/15 12:57, Jan Beulich wrote:
> >> >>>> On 20.04.15 at 12:49, <andrew.cooper3@xxxxxxxxxx> wrote:
> >> >> @@ -103,12 +88,20 @@ install: install-man-pages install-html
> >> >>  
> >> >>  # Individual file build targets
> >> >>  man1/%.1: man/%.pod.1 Makefile
> >> >> +ifdef POD2MAN
> >> > Perhaps better to use ifneq($(POD2MAN),) in such cases?
> >> 
> >> I was following the prevailing style, but can update all instances. 
> >> FWIW, it is not currently an issue.
> > 
> > I don't really mind, ifneq seems more prevalent in other makefiles, I'm
> > not sure why this one uses ifdef nor really what the implications are.
> 
> The difference becomes visible when the variable is defined but
> expands to nothing. And I view it as more useful if as empty
> variable means "none" than if that results in presumably very
> strange build errors.

True. Andy, will you fix these up then?




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel