Re: [Xen-devel] [PATCH V15 2/9] xen/arm: Allow hypervisor access to mem_access protected pages

[Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>]

On Tue, Apr 21, 2015 at 3:14 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:

On Mon, 2015-04-20 at 17:06 +0200, Tamas K Lengyel wrote:
> -paddr_t p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)
> +static paddr_t __p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)

I'd have been inclined to make this take a p2m_domain* rather than a
domain*, on the basis that the caller must have one in hand to have
locked it. I don't think __p2m_lookup uses d other than to find the p2m.

Not worth changing unless there is some other reason to resend though,
so with or without that:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.

Thanks, I made the change as I'll have another round anyway to introduce XENMEM_maximum_gpfn2 in the series.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel