Re: [Xen-devel] [PATCH] VT-d: replace bogus gprintk()

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Tuesday, April 21, 2015 3:31 PM
> 
> Just like the other messages in this function this one should be issued
> through plain printk() - the current vCPU is irrelevant here. (Noticed
> while backporting to older trees, which don't have gprintk().)
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> 
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -858,8 +858,8 @@ static int iommu_page_fault_do_one(struc
>          break;
>      }
> 
> -    gprintk(XENLOG_G_WARNING VTDPREFIX, "%s: reason %02x - %s\n",
> -            kind, fault_reason, reason);
> +    printk(XENLOG_G_WARNING VTDPREFIX "%s: reason %02x - %s\n",
> +           kind, fault_reason, reason);
> 
>      if ( iommu_verbose && fault_type == DMA_REMAP )
>          print_vtd_entries(iommu, PCI_BUS(source_id),
> PCI_DEVFN2(source_id),
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel