Re: [Xen-devel] [PATCH] tools/configure.ac: generate Paths.mk if it's not available

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-04-21 at 12:30 +0100, Wei Liu wrote:
> On Tue, Apr 21, 2015 at 11:54:27AM +0100, Ian Campbell wrote:
> > On Tue, 2015-04-21 at 11:16 +0100, Wei Liu wrote:
> > > On Mon, Apr 20, 2015 at 03:07:38PM +0100, Wei Liu wrote:
> > > > Xen toolstack references many variables in Paths.mk when building and
> > > > installing, so tools' configure should generate Paths.mk if it's not
> > > > available. Also make inclusion of Paths.mk mandatory in Tools.mk.
> > > 
> > > Hmm... I just discovered that docs build also involves Paths.mk.  This
> > > patch is ugly enough that I don't want to duplicate it for docs.
> > > So advise on how to fix this would be much appreciated.
> > 
> > I wasn't terribly happy with having more than one place update Paths.mk
> > already.
> > 
> > > Or we can state clear that anyone who builds Xen from source needs to
> > > run ./configure in top level directory, not the ones in subsystems.
> > 
> > I think that's essentially what we've done so far, but it's not terribly
> > satisfactory I'll admit. Is this the only issue which prevents this?
> > 
> > Perhaps change each subsystem to generate+consume its own Paths
> > ${subsys}.mk instead of a single global one? Either in config/Paths
> > ${subsys.mk} or in ${subsys}/Paths.mk.
> > 
> > If you invoke from the top-level then they will all end up with the same
> > contents, but so what...
> > 
> 
> I can try to refactor Paths.mk.in into several files.

I was suggesting a single input but create multiple outputs, otherwise
we have to keep all the inputs in sync.

I expect the majority of paths are common to all sub components.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel