Re: [Xen-devel] [PATCH] Config.mk: Fix (and, effectively, update) QEMU_TAG

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.04.15 at 12:33, <ian.jackson@xxxxxxxxxxxxx> wrote:
> In 952944f7 "QEMU_TAG update" my tag update script mangled the
> machinery which sets QEMU_TRADITIONAL_REVISION, by replacing the first
> assignment to QEMU_TRADITIONAL_REVISION it found rather than the one
> which ought to have been replaced.
> 
> The result was that:
>  * From that commit on, QEMU_TAG was no longer honoured although
>    QEMU_TRADITIONAL_REVISION still was
>  * That particular update to QEMU_TRADITIONAL_REVISION's default
>    value was effective
>  * The next attempt to update QEMU_TRADITIONAL_REVISION, in
>    1fc3aeb3 "libxl: use new QEMU xenstore protocol" was totally
>    ineffective.
> 
> Fix this by restoring the transfer from QEMU_TAG.  The effects are:
>  * Once more, honour QEMU_TAG.
>  * Belatedly apply the qemu-trad change part of "libxl: use new QEMU
>    xenstore protocol.
> 
> (I have also fixed my script to not do this again.)
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

(and please also for 4.5)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel