Re: [Xen-devel] [PATCH v5 03/13] x86: detect and initialize Intel CAT feature

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Mon, Apr 20, 2015 at 06:13:12PM +0200, Dario Faggioli wrote:
> On Fri, 2015-04-17 at 22:33 +0800, Chao Peng wrote:
> 
> > --- a/xen/arch/x86/psr.c
> > +++ b/xen/arch/x86/psr.c
> > @@ -19,14 +19,25 @@
> >  #include <asm/psr.h>
> >  
> >  #define PSR_CMT        (1<<0)
> > +#define PSR_CAT        (1<<1)
> > +
> > +struct psr_cat_socket_info {
> > +    bool_t initialized;
> > +    bool_t enabled;
> > +    unsigned int cbm_len;
> > +    unsigned int cos_max;
> > +};
> >
> Can't we ditch 'initialized' from within the struct and have a (global)
> bitmap, with one bit for each socket, expressing the same? And that also
> for 'enabled'.
> 
> It's probably, at least up to a certain extent, a matter of taste (and I
> personally think it will look better), but it also should produce
> tighter code...

NP, thanks.
Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel