Re: [Xen-devel] [PATCH 13/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDRA

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-04-21 at 13:26 +0500, Julien Grall wrote:
> Hi Ian,
> 
> On 17/04/2015 16:51, Ian Campbell wrote:
> >> Furthermore, this is the only registers not handled on AArch32 for this
> >> bit. This is rather strange to list them while you didn't do it for the
> >> trace registers.
> >
> > My intention was that every register trapped by a bit which we set be
> > listed somewhere, to make it easier to cross reference with the docs and
> > check we haven't accidentally forgotten something (as opposed to
> > deliberately ignoring as indicated by these comments).
> >
> > You seem to be saying I've missed some trace registers, which ones?
> 
> I meant that you didn't list the trace registers trapped but unhandled. 
> Although I wasn't able to find a list, is it trace module specific? If 
> so maybe a comment would be good?

I think maybe you are talking about the things trapped by CPTR_EL2.TTA
rather than MDCR_EL2.TDRA (the subject of this patch)?

The table referenced for CPTR_EL2.TTA just says "All implemented trace
registers", rather than listing anything specific. I could add a similar
comment to the relevant patch.

Looks like HCR_EL2.TIDCP is similarly lacking a comment for the
unhandled ones. I'll add one.

> 
> Regards,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel