Re: [Xen-devel] [PATCH 1/8] raisin: Fix non-verbose case

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 20 Apr 2015, Stefano Stabellini wrote:
> On Mon, 20 Apr 2015, George Dunlap wrote:
> > On 04/17/2015 11:06 AM, Stefano Stabellini wrote:
> > > On Thu, 16 Apr 2015, George Dunlap wrote:
> > >> Because we use "set -e", we can't use the "a && b" construct, as it will 
> > >> fail and stop the script.
> > >>
> > >> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > > 
> > > I am wondering whether we should ban both a && b and a || b from the
> > > code and just go with the more verbose but also harder to get wrong:
> > > 
> > > if [[ $VERBOSE -eq 1 ]]
> > > then
> > >     echo calling "$component"_"$1"
> > > fi
> > > 
> > > Reading the code and seeing a || b will tempt you into writing a && b.
> > 
> > That's a good point. :-)  Do you want to go it or shall I resend?
> 
> Given that you have a couple of other patches to resend, you might as
> well resend this one too.

I made the change and committed it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel