Re: [Xen-devel] [PATCH v20 02/13] x86/VPMU: Add public xenpmu.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.15 at 17:44, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/include/public/pmu.h
> @@ -0,0 +1,38 @@
> +#ifndef __XEN_PUBLIC_PMU_H__
> +#define __XEN_PUBLIC_PMU_H__
> +
> +#include "xen.h"
> +#if defined(__i386__) || defined(__x86_64__)
> +#include "arch-x86/pmu.h"
> +#elif defined (__arm__) || defined (__aarch64__)
> +#include "arch-arm.h"
> +#else
> +#error "Unsupported architecture"
> +#endif
> +
> +#define XENPMU_VER_MAJ    0
> +#define XENPMU_VER_MIN    1
> +
> +
> +/* Shared between hypervisor and PV domain */
> +struct xen_pmu_data {

Iirc this sharing is r/o - if so, please state so in the comment. If not,
please extend the comment to briefly explain why writable sharing
is safe/secure. Apart from that the comment is missing a final stop
(there are several more such comments elsewhere in this patch,
but most/all of them aren't really sentence like, so I'd let them go
without full stop even if our coding style says otherwise).

With this adjusted
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel