Re: [Xen-devel] [PATCH 6/8] raisin: Break build into components and allow the sub-steps to be called individually

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 16 Apr 2015, George Dunlap wrote:
> This makes it easier to debug just one aspect of the build.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> ---
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> ---
>  lib/commands.sh | 16 ++++++++++++----
>  raise           |  2 +-
>  2 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/commands.sh b/lib/commands.sh
> index 17e2129..c5df9ad 100755
> --- a/lib/commands.sh
> +++ b/lib/commands.sh
> @@ -45,17 +45,25 @@ function install-builddep() {
>      YES=y check-builddep
>  }
>  
> -function build() {
> -    check-builddep
> -    
> +function build-only() {
>      mkdir -p "$INST_DIR" &>/dev/null
>  
>      # build and install under $DESTDIR
>      for_each_component build
> -    
> +}
> +
> +function build-package() {
>      build_package xen-system
>  }
>  
> +function build() {
> +    check-builddep
> +
> +    build-only
> +
> +    build-package
> +}
> +
>  function unraise() {
>      for_each_component clean
>  
> diff --git a/raise b/raise
> index bce6908..59de04a 100755
> --- a/raise
> +++ b/raise
> @@ -64,7 +64,7 @@ do
>  done
>  
>  case "$1" in
> -    "install-builddep" | "build" | "install" | "configure" | "unraise" )
> +    "install-builddep" | "build" | "build-only" | "build-package" | 
> "install" | "configure" | "unraise" )
>          COMMAND=$1
>          ;;
>      *)

You have added two new commands, but they are not documented in the help
function or in the README. As they stand they are "hidden" commands. Is
that on purpose because they are supposed to be used just for debugging?
Maybe it would be worth documenting debugging functions too somewhere.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel