Re: [Xen-devel] [PATCH v7] libxl: provide libxl_bitmap_{or,and}

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-04-15 at 11:02 -0600, Linda Jacobson wrote:
> New functions to provide logical and and or of two bitmaps functions can be
> used in vNUMA configuration check function.

I don't think that really justifies adding them, since we aren't
actually using them for that now, how about:

        New functions to provide logical and and or of two bitmaps.
        These are generically useful utility functions added to the
        public API for the benefit of libxl's users.
        
        In the future they may also be useful internally, e.g. in the
        vNUMA configuration check function.

If you are happy with that, and there's no other reason to resend, then
I can switch in that text as I commit.

> Signed-off-by: Linda Jacobson <lindaj@xxxxxxxx>
> 
> ---
> 
> v.1 The new functions were added.
> v.2 The comments and format were corrected.
> v.3 The bitmap functions were rewritten to manipulate bytes not bits.
> v.4 Several non-modified parameters, and local variables were changed to const
>     Also the code formatting was fixed.
> v.5 The commit subject line now has versions and is simpler.
> v.6 All descriptions in the commit history are now complete sentences.
>     Extraneous blank lines are gone.
> v.7 Added LIBXL_BIT_HAVE_AND_OR to libxl.h; deleted extraneous comment in
>     libxl_utils.h; and updated the commit log to include the uses for these
>     functions
> ---
>  tools/libxl/libxl.h       |  9 ++++++
>  tools/libxl/libxl_utils.c | 70 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  tools/libxl/libxl_utils.h |  6 ++++
>  3 files changed, 85 insertions(+)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 5eec092..1fb9549 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -84,6 +84,15 @@
>  #define LIBXL_HAVE_CPUPOOL_QUALIFIER_TO_CPUPOOLID 1
>  
>  /*
> + *
> + * LIBXL_HAVE_BITMAP_AND_OR
> + *
> + * If this is defined, libxl has two libarary functions, libxl_bitmap_and

"library".

(again, can fix on commit)

Other than those:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel