Re: [Xen-devel] Error in gnttab documentation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.04.15 at 21:47, <omeg@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> There is an erroneous statement in the public header grant_table.h
> regarding GNTTABOP_map_grant_ref:
> 
> "On error, <handle> is a negative status code." [1]
> 
> This is not the case. Only the gnttab_map_grant_ref.status field is
> set on errors most of the time. [2]

First of all - why didn't you simply send a patch to correct this? And
then - why do you say "most of the time"? Is there any path which
fails to do so, or sets .handle to some error indicator? I can't seem
to be able to spot any...

Jan

> [1]
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/gra 
> nt_table.h;h=c8619ed50dda6d3b1bdc73faeb5622f5eccad1ac;hb=refs/heads/mast
> er#l324
> 
> [2]
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/common/grant_table 
> .c;h=dfb45f8d6661fc60379abd29597bc23e55d674ff;hb=refs/heads/master#l591
> 
> - -- 
> RafaÅ WojdyÅa
> Qubes Tools for Windows developer
> https://www.qubes-os.org/ 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel