Re: [Xen-devel] [PATCH 16/28] libxl: ao: Provide manip_refcnt

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-31 at 20:00 +0100, Ian Jackson wrote:
> Previously we used in_initiator to stop the ao being freed while we
> were still in the initiator function (which would result in the
> initiator's call to lixl__ao_inprogress accessing the ao after it had
> been freed).
> 
> We are going to introduce a new libxl entrypoint which finds, and
> operates on, ongoing aos.  This function needs the same protection,
> and might even end up running on the same ao multiple times
> concurrently.
> 
> So do this with reference counting instead, with a new variable
> ao->manip_refcnt.
> 
> We keep ao->in_initiator because that allows us to keep some useful
> asserts about the sequencing of libxl__ao_inprogress, etc.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel