Re: [Xen-devel] [RFC PATCH COLO v5 03/29] tools: libxl: introduce a new API libxl__domain_restore() to read qemu state

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [RFC PATCH COLO v5 03/29] tools: libxl: introduce a new 
API libxl__domain_restore() to read qemu state"):
> On Wed, Apr 01, 2015 at 02:41:39PM +0800, Yang Hongyang wrote:
> > +    case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> > +        /*
> > +         * This function may be called too many times for the same gc,
> > +         * so we use NOGC, and free the memory before return to avoid
> > +         * OOM.
> > +         */
> 
> Hmm...

I agree that this is doubtful.

The underlying problem is that in remus a migration send, as well as a
migration receive, are long-running.

I think more thought needs to be given to this area.  It may be
necessary to introduce a nested ao.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel