Re: [Xen-devel] [PATCH v9 10/15] tools/libxc: x86 HVM save code

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-04-13 at 14:21 +0100, Andrew Cooper wrote:
> >> +static int write_hvm_params(struct xc_sr_context *ctx)
> >> +{
> >> +    static const unsigned int params[] = {
[...]
> > While reviewing my 'soft reset' series Ian C raised a question about the
> > unsafeness of sequential get/set of HVM params:
> > http://lists.xen.org/archives/html/xen-devel/2015-01/msg01177.html
> >[...]
> This code currently mirrors what the old migration did.  This was one
> area we deliberately didn't try to clean up (we were focusing on a
> functional replacement).

Apart from what else you say (which I agree with) I think all Vitaly was
asking here was whether your params[] array could be moved into a
location which was accessible to the rest of libxc.

In any case I would say it would be fine for the second user to refactor
out any list which the first one added. Gentlemen, start your
engines ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel