Re: [Xen-devel] [PATCH v5 p2 16/19] tools/libxl: arm: Use an higher value for the GIC phandle

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 09/04/15 18:04, Ian Jackson wrote:
> Julien Grall writes ("Re: [Xen-devel] [PATCH v5 p2 16/19] tools/libxl: arm: 
> Use an higher value for the GIC phandle"):
>> On 09/04/15 17:52, Ian Jackson wrote:
>>> What would happen if our assumption about the DT compiler were
>>> violated ?
>>
>> The phandle would be present in 2 different nodes of the DT. FYI, that
>> may also happen if a user use 2 times the same phandle in the partial DT.
> 
> So we are making an assumption about the DT compiler which we don't
> check, and when the assumption is violated, we produce a corrupted DT
> which produces undefined behaviour in the guest.
> 
> Can we do some kind of check ?

As discussed IRL, I will add a note in the documentation about this
restriction.

This will be removed when the phandle will be generated dynamically.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel