[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/8] x86: detect and initialize Intel CAT feature



>>> On 27.03.15 at 19:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/03/15 12:38, Chao Peng wrote:
>> +    cpuid_count(PSR_CPUID_LEVEL_CAT, 0, &eax, &ebx, &ecx, &edx);
>> +    if ( ebx & PSR_RESOURCE_TYPE_L3 )
>> +    {
>> +        cpuid_count(PSR_CPUID_LEVEL_CAT, 1, &eax, &ebx, &ecx, &edx);
>> +        info->cbm_len = (eax & 0x1f) + 1;
>> +        info->cos_max = (edx & 0xffff);
>> +
>> +        info->enabled = 1;
>> +        printk(XENLOG_DEBUG "CAT: enabled on socket %u, cos_max:%u, 
>> cbm_len:%u\n",
>> +               socket, info->cos_max, info->cbm_len);
> 
> I would bump this to INFO, at least for socket 0.  Similar to CMT, a
> user which has gone to the effort of enabling CAT will want some
> indication in the boot log without also having to bump the logging level.

Which INFO wouldn't be sufficient for (at least not with the xen.org
defaults, not sure about XenServer's).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.