Re: [Xen-devel] [PATCH 1/8] Add core.sh and wrapper function

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 04/10/2015 03:29 PM, Stefano Stabellini wrote:
>> diff --git a/raise b/raise
>> new file mode 100755
>> index 0000000..7f3faae
>> --- /dev/null
>> +++ b/raise
>> @@ -0,0 +1,16 @@
>> +#!/usr/bin/env bash
> 
> It is important to "set -e" immediately to catch all possible errors:
> 
>  "-e  Exit immediately if a command exits with a non-zero status."
> 
> Then you can drop set -e from raise.sh and unraise.sh when you turn them
> into libraries.

"set -e" gets tricky when you sometimes expect commands to fail;
particularly if you may want to do some sort of clean-up.  But let's
cross that bridge when we come to it. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel