Re: [Xen-devel] [PATCH] Added function prototypes to libxl_utils.h and function definitions to libxl_utils.c for the logical 'or'-ing and logical 'and'-ing of two bitmaps

[Linda <lindaj@xxxxxxxx>]

On 4/10/2015 5:23 AM, Wei Liu wrote:
> Now really CC xen-devel. :-/
>
> On Fri, Apr 10, 2015 at 12:22:02PM +0100, Wei Liu wrote:
> > CC xen-devel. Please use reply-all in the future.
> >
> > On Fri, Apr 10, 2015 at 05:16:26AM -0600, Linda wrote:
> > > a few questions below, and I'll make all the changes you suggest.
> > >
> > > On 4/10/2015 2:56 AM, Wei Liu wrote:
> > > > Please edit the subject line to be more concise. Something like:
> > > >    libxl: provide libxl_bitmap_{and,or}
> > > >
> > > > On Thu, Apr 09, 2015 at 07:51:28PM -0600, Linda Jacobson wrote:
> > > > > Linda Jacobson
> > > > You need to properly sign off this patch. See
> > > >
> > > >    http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches
> > > >
> > > > > ---
> > > > >   tools/libxl/libxl_utils.c   | 51 +++++++++++++++++++++++++++++++++++++++++++++
> > > > >   tools/libxl/libxl_utils.h   |  6 ++++++
> > > > >   tools/libxl/libxlu_disk_l.c |  8 ++-----
> > > > >   tools/libxl/libxlu_disk_l.h |  6 +-----
> > > > The changes to libxlu_disk_* are not necessary. Presumably this is due
> > > > to you have different version of bison / flex installed.
> > > >
> > > > I guess you used "git commit -a" to commit all the changes, right?
> > > >
> > > > To avoid committing unrelated changes, you can use
> > > >
> > > >     $ git add libxl_utils.c
> > > >     $ git add libxl_utils.h
> > > >     $ git commit -s
> > > >
> > > > to only commit changes to libxl_utils.{c,h}.
> > > >
> > > > (the "-s" for git commit will nicely generate a Signed-off-by line for
> > > > you, provided you have configured your name and email properly in git)
> > > I hope I configured my name and email properly - I used git user.name (Linda
> > > Jacobson) and git user.email (lindaj@xxxxxxxx).  Is that correct?  I think
> > I think so.
> >
> > > that the -s is the way I did it last time, because it did give
> > > me a signature.
> > Yes, that's what we want.
> >
> > > So how do I uncommit the things I accidentally committed?
> > git reset HEAD^ can reset your commit (provided the first commit in your
> > tree is this commit).
> >
> > Wei.
It should be.  I've got to go now, but the fixes will be in late today 
(mid-day here).
And thanks, for all your help and guidance.

Linda

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel