Re: [Xen-devel] [PATCH 2/8] Remove redundant "source" from component definitions

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 9 Apr 2015, George Dunlap wrote:
> These should be called from other places that have already done the
> appropriate "source"
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Yes, you are right about that. I committed this.


> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> ---
>  components/grub    | 4 ----
>  components/libvirt | 4 ----
>  components/xen     | 4 ----
>  3 files changed, 12 deletions(-)
> 
> diff --git a/components/grub b/components/grub
> index ab4f583..5a42000 100644
> --- a/components/grub
> +++ b/components/grub
> @@ -1,9 +1,5 @@
>  #!/usr/bin/env bash
>  
> -source "$BASEDIR"/config
> -source "$BASEDIR"/scripts/common-functions.sh
> -
> -
>  function _grub_install_dependencies() {
>      local DEP_Debian_common="build-essential tar autoconf bison flex"
>      local DEP_Debian_x86_32="$DEP_Debian_common"
> diff --git a/components/libvirt b/components/libvirt
> index e35de8c..e22996e 100644
> --- a/components/libvirt
> +++ b/components/libvirt
> @@ -1,9 +1,5 @@
>  #!/usr/bin/env bash
>  
> -source "$BASEDIR"/config
> -source "$BASEDIR"/scripts/common-functions.sh
> -
> -
>  function _libvirt_install_dependencies() {
>      local DEP_Debian_common="build-essential libtool autoconf autopoint \
>                               xsltproc libxml2-utils pkg-config python-dev   \
> diff --git a/components/xen b/components/xen
> index d6286b2..a49a1d1 100644
> --- a/components/xen
> +++ b/components/xen
> @@ -1,9 +1,5 @@
>  #!/usr/bin/env bash
>  
> -source "$BASEDIR"/config
> -source "$BASEDIR"/scripts/common-functions.sh
> -
> -
>  function _xen_install_dependencies() {
>      local DEP_Debian_common="build-essential python-dev gettext uuid-dev   \
>               libncurses5-dev libyajl-dev libaio-dev pkg-config 
> libglib2.0-dev  \
> -- 
> 1.9.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel