[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v15 13/15] pvqspinlock: Only kick CPU at unlock time



On 04/09/2015 03:57 PM, Peter Zijlstra wrote:
On Mon, Apr 06, 2015 at 10:55:48PM -0400, Waiman Long wrote:

@@ -219,24 +236,30 @@ static void pv_wait_node(struct mcs_spinlock *node)
  }

  /*
+ * Called after setting next->locked = 1&  lock acquired.
+ * Check if the the CPU has been halted. If so, set the _Q_SLOW_VAL flag
+ * and put an entry into the lock hash table to be waken up at unlock time.
   */
-static void pv_kick_node(struct mcs_spinlock *node)
+static void pv_scan_next(struct qspinlock *lock, struct mcs_spinlock *node)
I'm not too sure about that name change..

It is because the function will no longer kick the cpu. So I change the name to reflect that. I am not good at naming. Please let me know if you have a better name.

Cheers,
Longman


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.