Re: [Xen-devel] [PATCH 2/6] x86/numa: Correct the extern of cpu_to_node

[Tim Deegan <tim@xxxxxxx>]

At 18:26 +0100 on 07 Apr (1428431176), Andrew Cooper wrote:
> --- a/xen/include/asm-x86/numa.h
> +++ b/xen/include/asm-x86/numa.h
> @@ -9,7 +9,7 @@
>  
>  extern int srat_rev;
>  
> -extern unsigned char cpu_to_node[];
> +extern nodeid_t      cpu_to_node[NR_CPUS];

Does the compiler do anything useful with the array size here? In
particular does it check that it matches the size at the definition?
If not, I think it's best to leave it as '[]'.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel