Re: [Xen-devel] [PATCH 2/3] blkif: enable multi-page ring supporting

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 03/04/15 07:45, Bob Liu wrote:
> Remove the 'DEPRECATED' and next patch will follow the protocol defined here 
> to
> support multi-page ring.

Why are you un-deprecating this instead of using max-ring-page-order?
Are you allowing for non power of two counts? If so, the documentation
needs to be updated as well.

Also num-ring-pages is also tagged as deprecated.

Changes in blkif.h need to be made in Xen first.

David

> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -303,7 +303,7 @@
>   *      Values:         <uint32_t>
>   *      Default Value:  1
>   *      Maximum Value:  MAX(max-ring-pages,(0x1 << max-ring-page-order))
> - *      Notes:          DEPRECATED, 2, 3
> + *      Notes:          2, 3
>   *
>   *      The size of the frontend allocated request ring buffer in units of
>   *      machine pages.  The value must be a power of 2.
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel