Re: [Xen-devel] [PATCH] hvmloader: fix building error

[Wen Congyang <wency@xxxxxxxxxxxxxx>]

On 04/08/2015 04:46 PM, Andrew Cooper wrote:
> On 08/04/15 08:33, Wen Congyang wrote:
>> On 04/08/2015 03:28 PM, Olaf Hering wrote:
>>> On Wed, Apr 08, Wen Congyang wrote:
>>>
>>>> On 04/08/2015 03:21 PM, Olaf Hering wrote:
>>>>> On Wed, Apr 08, Wen Congyang wrote:
>>>>>
>>>>>> commit b9245b75 introduces a building error:
>>>>>> make[1]: Entering directory `/root/work/xen/tools/firmware/hvmloader'
>>>>>> gcc   -O1 -fno-omit-frame-pointer -m32 -march=i686 -g 
>>>>>> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes 
>>>>>> -Wdeclaration-after-statement   -O0 -g3 -D__XEN_TOOLS__ -MMD -MF 
>>>>>> .smbios.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
>>>>>> -fno-optimize-sibling-calls -mno-tls-direct-seg-refs  -Werror 
>>>>>> -fno-stack-protector -fno-exceptions -fno-builtin -msoft-float 
>>>>>> -I/root/work/xen/tools/firmware/hvmloader/../../../tools/include 
>>>>>> -DENABLE_ROMBIOS -DENABLE_SEABIOS -D__SMBIOS_DATE__="04/08/2015"  -c -o 
>>>>>> smbios.o smbios.c
>>>>>> smbios.c:384:46: error: invalid digit "8" in octal constant
>>>>>> smbios.c:792:46: error: invalid digit "8" in octal constant
>>>>>> make[1]: *** [smbios.o] Error 1
>>>>> Oh, I did not spot that because in my builds the octal number was always
>>>>> valid. But you are right, it has to be a string constant.
>>>> Do you run 'make -C tools/ clean' before building?
>>> No, I dont. I do 'git clean -dffx', often.
>> I guess if you do it, you will also find this problem.
> 
> It will entirely depend on whether you attempt to compile it on an 8th
> or 9th of a month, or in August or September.  Outside of that that
> window, the resulting number will parse correctly and not fail to compile.

Yes, outside of that window, the problem is hidden.

> 
> For the fix itself, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> .
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel