[Xen-devel] [PATCH v1] arm: irq: increase size of irq from uint8_t to uint32_t

[Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>]

From: Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>

On some platforms IRQ number can be greater then 255, so
greater size for IRQ is needed to avoid overflow for some
structure fileds and paramters. It concerns
XEN_DOMCTL_irq_permission and IRQ pssthrough API functions.
---
 tools/libxc/include/xenctrl.h | 10 +++++-----
 tools/libxc/xc_domain.c       | 10 +++++-----
 xen/include/public/domctl.h   |  2 +-
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index 44c7ac0..c08c4da 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -1401,7 +1401,7 @@ int xc_domain_ioport_permission(xc_interface *xch,
 
 int xc_domain_irq_permission(xc_interface *xch,
                              uint32_t domid,
-                             uint8_t pirq,
+                             uint32_t pirq,
                              uint8_t allow_access);
 
 int xc_domain_iomem_permission(xc_interface *xch,
@@ -2087,7 +2087,7 @@ int xc_domain_unbind_msi_irq(xc_interface *xch,
 
 int xc_domain_bind_pt_irq(xc_interface *xch,
                           uint32_t domid,
-                          uint8_t machine_irq,
+                          uint32_t machine_irq,
                           uint8_t irq_type,
                           uint8_t bus,
                           uint8_t device,
@@ -2096,7 +2096,7 @@ int xc_domain_bind_pt_irq(xc_interface *xch,
 
 int xc_domain_unbind_pt_irq(xc_interface *xch,
                           uint32_t domid,
-                          uint8_t machine_irq,
+                          uint32_t machine_irq,
                           uint8_t irq_type,
                           uint8_t bus,
                           uint8_t device,
@@ -2105,14 +2105,14 @@ int xc_domain_unbind_pt_irq(xc_interface *xch,
 
 int xc_domain_bind_pt_pci_irq(xc_interface *xch,
                               uint32_t domid,
-                              uint8_t machine_irq,
+                              uint32_t machine_irq,
                               uint8_t bus,
                               uint8_t device,
                               uint8_t intx);
 
 int xc_domain_bind_pt_isa_irq(xc_interface *xch,
                               uint32_t domid,
-                              uint8_t machine_irq);
+                              uint32_t machine_irq);
 
 int xc_domain_set_machine_address_size(xc_interface *xch,
                                       uint32_t domid,
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index 95e3098..3132d19 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1271,7 +1271,7 @@ int xc_vcpu_setcontext(xc_interface *xch,
 
 int xc_domain_irq_permission(xc_interface *xch,
                              uint32_t domid,
-                             uint8_t pirq,
+                             uint32_t pirq,
                              uint8_t allow_access)
 {
     DECLARE_DOMCTL;
@@ -1775,7 +1775,7 @@ int xc_domain_unbind_msi_irq(
 int xc_domain_bind_pt_irq(
     xc_interface *xch,
     uint32_t domid,
-    uint8_t machine_irq,
+    uint32_t machine_irq,
     uint8_t irq_type,
     uint8_t bus,
     uint8_t device,
@@ -1816,7 +1816,7 @@ int xc_domain_bind_pt_irq(
 int xc_domain_unbind_pt_irq(
     xc_interface *xch,
     uint32_t domid,
-    uint8_t machine_irq,
+    uint32_t machine_irq,
     uint8_t irq_type,
     uint8_t bus,
     uint8_t device,
@@ -1857,7 +1857,7 @@ int xc_domain_unbind_pt_irq(
 int xc_domain_bind_pt_pci_irq(
     xc_interface *xch,
     uint32_t domid,
-    uint8_t machine_irq,
+    uint32_t machine_irq,
     uint8_t bus,
     uint8_t device,
     uint8_t intx)
@@ -1870,7 +1870,7 @@ int xc_domain_bind_pt_pci_irq(
 int xc_domain_bind_pt_isa_irq(
     xc_interface *xch,
     uint32_t domid,
-    uint8_t machine_irq)
+    uint32_t machine_irq)
 {
 
     return (xc_domain_bind_pt_irq(xch, domid, machine_irq,
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 8803ab2..65fb866 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -400,7 +400,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_setdebugging_t);
 
 /* XEN_DOMCTL_irq_permission */
 struct xen_domctl_irq_permission {
-    uint8_t pirq;
+    uint32_t pirq;
     uint8_t allow_access;    /* flag to specify enable/disable of IRQ access */
 };
 typedef struct xen_domctl_irq_permission xen_domctl_irq_permission_t;
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel