Re: [Xen-devel] [PATCH] tools/libxl new bitmap functions

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2015-04-02 at 15:34 -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Apr 02, 2015 at 11:38:16AM -0600, Linda Jacobson wrote:
> > --- a/tools/libxl/libxl_utils.c
> > +++ b/tools/libxl/libxl_utils.c

> > +        goto out;
> > +    }
> > +
> > +    for (int bit = 0; bit < (size * 8); bit++)
> 
> Please move the 'int bit' to the start of the function.
> 
Or, even better, use libxl_for_each_bit, defined in libxl_utils.h. :-)

(I wanted to say this in my previous mail, while commenting about the
name of the functions and about the long lines, but forgot. :-D)

Regards,
Dario

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel