Re: [Xen-devel] [PATCH OSSTEST v4 01/25] TestSupport: Add helper to fetch a URL on a host

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-04-02 at 12:24 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v4 01/25] TestSupport: Add helper to 
> fetch a URL on a host"):
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> We're not using this to fetch URLs on the public internet, are we ?
> If we are then we need to honour $c{HttpProxy}.

It is used to fetch the kernel+initrd to test, which previously came
from the apt cache, via $c{DebianMirrorHost}.

Would you recommend $c{HttpProxy} or ${DebianMirrorProxy} for this? I
think given the generic nature only the former, even though the only
caller is currently grabbing apt-cachable things.

> Perhaps you could add a comment to the effect that target_fetch_url
> should be used for URLs within the test environment, only.
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel