Re: [Xen-devel] [PATCH OSSTEST v4 03/25] create_webfile: Support use with guests as well as hosts.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v4 03/25] create_webfile: Support use with 
guests as well as hosts."):
> In particular make the path unique by ensuring it includes the host
> and guest name in the guest case.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

But I have a minor style quibble:

> +    # $ho->{Host} is set if $ho is a guest.
> +    $wf_rhs= $ho->{Host}->{Name}."_${wf_rhs}" if $ho->{Host};

It would be usual to write

  +    $wf_rhs= $ho->{Host}{Name}."_${wf_rhs}" if $ho->{Host};

since only the first -> is required.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel