Re: [Xen-devel] [PATCH OSSTEST 5/5] cambridge: Stop publishing logs to chiark

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST 5/5] cambridge: Stop publishing logs to 
chiark"):
> http://osstest.cam.xci-test.com/~osstest/testlogs already exists and
> points to the live logs directory, so switch PubBaseUrl to that in the
> Cambridge config such that email reports etc contain it. This won't be
> externally accessible but I think that won't matter now that the
> master production instance is elsewhere.
> 
> Arrange that cr-publish-flight-logs doesn't publish the corresponding
> thing if either LogsPublish or ResultsPublish is not set, and unset
> them in the Cambridge config.
> 
> Likewise arrange that cr-ensure-disk-space doesn't do anything if the
> configuration variable passed as an option is not set, and unset
> Publish (the base for {Logs,Results}Publish) in the Cambridge config.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  cr-ensure-disk-space        | 2 ++
>  cr-publish-flight-logs      | 4 ++--
>  production-config-cambridge | 6 +-----
>  3 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/cr-ensure-disk-space b/cr-ensure-disk-space
> index 0ee84c7..84b1890 100755
> --- a/cr-ensure-disk-space
> +++ b/cr-ensure-disk-space
> @@ -40,6 +40,8 @@ die unless @ARGV==1;
>  
>  our ($cfgbase) = @ARGV;
>  
> +exit 0 unless $cfgbase;
>  
>  csreadconfig();

Don't you mean "unless $c{$cfgbase}" ?  And then it has to come after
csreadconfig.  (Did you test this ?)

The rest LGTM.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel