Re: [Xen-devel] [PATCH 4/4] hvmloader: add knob for fixed VGABIOS date string

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-04-01 at 13:28 +0000, Olaf Hering wrote:
> To allow reproducible builds of hvmloader introduce a make variable
> VGABIOS_REL_DATE="dd Mon yyyy" to provide a fixed date string. Without
> this change the hvmloader binary changes with every rebuild.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

It's not clear if vgabios should be maintained by us tools folks or if
it should have been taken under the hvmloader umbrella and maintained by
the hypervisor folks.

I've CC-d Jan, but I'm not going to block on an ack.

> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  INSTALL                         | 1 +
>  tools/firmware/vgabios/Makefile | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index bf412ef..a0f2e7b 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -217,6 +217,7 @@ can be used to provide fixed timestamps in the expected 
> format.
>  XEN_BUILD_DATE=<output of date(1)>
>  XEN_BUILD_TIME=hh:mm:ss
>  SMBIOS_REL_DATE=mm/dd/yyyy
> +VGABIOS_REL_DATE="dd Mon yyyy"
>  
>  The following variables can be used to tweak some aspects of the
>  hypervisor build.
> diff --git a/tools/firmware/vgabios/Makefile b/tools/firmware/vgabios/Makefile
> index 51d9e6e..3284812 100644
> --- a/tools/firmware/vgabios/Makefile
> +++ b/tools/firmware/vgabios/Makefile
> @@ -5,10 +5,10 @@ BCC = bcc
>  AS86 = as86
>  
>  RELEASE = `pwd | sed "s-.*/--"`
> -RELDATE = `date '+%d %b %Y'`
> +VGABIOS_REL_DATE ?= `date '+%d %b %Y'`
>  RELVERS = `pwd | sed "s-.*/--" | sed "s/vgabios//" | sed "s/-//"`
>  
> -VGABIOS_DATE = "-DVGABIOS_DATE=\"$(RELDATE)\""
> +VGABIOS_DATE = "-DVGABIOS_DATE=\"$(VGABIOS_REL_DATE)\""
>  
>  .PHONY: all
>  all: bios cirrus-bios



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel