Re: [Xen-devel] [PATCH 24/29] libxl: Introduce FILLZERO

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-31 at 19:51 +0100, Ian Jackson wrote:

> > > No callers yet, but document it in CODING_STYLE.  (In accordance with
> > > existing libxl policy, I haven't gone through all existing possible
> > > call sites.)
> > 
> > We don't usually expose such helpers in the public API, but I suppose
> > you have a good reason to do so here, could you mention it in the commit
> > log please.
> 
> It should be in the public API because xl*.c is full of uses of memset
> which ought to be replaced with FILLZERO.  Do you really think I need
> to mention this in the commit message ?

I suppose not.

> > > +#define LIBXL_FILLZERO(object) (memset(&(object), 0, sizeof((object))))
> > 
> > Evaluates object twice, so LIBXL_FILEZERO(*(p++)), would behave
> > surprisingly. I'm not sure if this can be resolved though, so this might
> > be a Don't Do That Then situation.
> 
> sizeof() does not evaluate its argument.

Useful!


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel