Re: [Xen-devel] [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-31 at 17:48 +0100, Stefano Stabellini wrote:
> If it helps we could add a couple of comments on top of the structs in
> smmu.c to explain the meaning of the fields, like:
> 
> 
> /* iommu_domain, not to be confused with a Xen domain */

I was going to suggest something similar but more expansive, i.e. a
table of them all in one place (i.e. at the top of the file) for ease of
referencing:

Struct Name            What             Wherefrom     Normally found in
---------------------------------------------------------------------
iommu_domain           IOMMU Context    Linux         d->arch.blah
arch_smmu_xen_device   Device specific  Xen           device->arch.blurg 

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel