Re: [Xen-devel] [OSSTEST Nested PATCH v7 3/6] Changes on test step of debain hvm guest install

["Pang, LongtaoX" <longtaox.pang@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> Sent: Tuesday, March 31, 2015 9:56 PM
> To: Pang, LongtaoX
> Cc: xen-devel@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; wei.liu2@xxxxxxxxxx;
> Hu, Robert
> Subject: Re: [OSSTEST Nested PATCH v7 3/6] Changes on test step of debain
> hvm guest install
> 
> On Fri, 2015-03-27 at 19:06 -0400, longtao.pang wrote:
> > 1. Increase disk size to accomodate to nested test requirment.
> 
> "accommodate" and "requirement"
> 
> Ian, are you OK with this generic change or would you prefer a runvar? I
> suspect the answer is going to be runvar.
> 
So, should I waiting for Ian Jackson's reply and then take next action?
> > 2. Since 'Debain-xxx-.iso' image will be stored there, therefore needs
> > more disk capacity, increase root partition size in preseed generation.
> 
> "Debian".
> 
> I'm not sure I follow what this one is saying though, does "there" refer to 
> the
> rootfs of the VM which is being built here?
Yes.
> 
> > @@ -75,6 +75,7 @@ d-i preseed/late_command string \\
> >          in-target mkdir -p /boot/efi/EFI/boot; \\
> >          in-target cp /boot/efi/EFI/debian/grubx64.efi
> /boot/efi/EFI/boot/bootx64.efi ;\\
> >          in-target mkdir -p /root/.ssh; \\
> > +        in-target sed -i '/^deb *cdrom/s/^/#/' /etc/apt/sources.list;
> > + \\
> 
> I think a more conventional way to do this would be to use:
>         s/^deb *cdrom/#&/g
> 
> >          in-target sh -c "echo -e '$authkeys'>
> > /root/.ssh/authorized_keys";  END
> >      return $preseed_file;
> > @@ -152,6 +153,7 @@ sub prep () {
> >      more_prepareguest_hvm($ho,$gho, $ram_mb, $disk_mb,
> >                            OnReboot => 'preserve',
> >                            Bios => $r{bios},
> > +                          ExtraConfig => 'nestedhvm=1',
> 
> Please do only for the nested job i.e. using a runvar.
I remembered in previous mail you mentioned as below:
"One good thing about just enabling it from the start is that we get some 
testing of normal guest installation while nestedhvm happens to be installed, 
which might help catch regressions."
Therefore, I enabled 'nestedhvm' feature as generally. 
> 
> >                            PostImageHook => sub {
> >          my $cmds = iso_copy_content_from_image($gho, $newiso);
> >          $cmds .=
> > prepare_initrd($initrddir,$newiso,$preseed_file_path);
> > @@ -173,6 +175,8 @@ my $ram_minslop = 100;  my $ram_lots = 5000;  if
> > ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) {
> >      $ram_mb = $ram_lots;
> > +} elsif ($gn eq 'nested') {
> > +    $ram_mb = 3072;
> 
> I think this ought to be driven from a runvar as well, e.g. <gn>_minram.
> 
> >  } else {
> >      $ram_mb = 768;
> >  }
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel