[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/29] libxl: suspend: switch_logdirty_done takes rc



Ian Campbell writes ("Re: [Xen-devel] [PATCH 03/29] libxl: suspend: 
switch_logdirty_done takes rc"):
> On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote:
> > +    int broke;
> > +    if (rc) {
> > +        broke = -1;
> > +    } else {
> > +        broke = 0;
> > +    }
> 
> int broke = rc ? -1 : 0;
> 
> ?
> 
> But it looks like perhaps you are preparing to add other code in one or
> the other case, or maybe you just prefer this for some reason. Either
> way:

Later we change one of the branches to set dss->rc too.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.