[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v4] Fix xl vcpu-set to decrease an guest vCPU amoutn without complaints.



Hey Ian and Ian,

Since v3 [http://lists.xen.org/archives/html/xen-devel/2015-03/msg02822.html]
- Constify the libxl_dominfo and handle libxl_domain_info errors.
- Made libxl_domain_info use logging if domain is gone.
- Drop libxl: Add to libxl__domain_type a new return value 
(LIBXL_DOMAIN_TYPE_NOTFOUND)

In v2 [http://lists.xen.org/archives/html/xen-devel/2015-03/msg01787.html]:
 - Fixed up #1 "libxl: Add ERROR_DOMAIN_NOTFOUND for libxl_domain_info" per 
your review.
 - Moved the check from vcpuset to libxl_set_vcpuonline to check if the set 
bits of the
   cpumap is greater than the maximum vCPU that the guest can have (and added 
printks).
 - Added LIBXL_DOMAIN_TYPE_NOTFOUND so that libxl_set_vcpuonline can report 
that the
   domain id is for an non-existent guest.
 - Added an #define in libxl.h to expose the new _NOTFOUND error value.

 git://xenbits.xen.org/people/konradwilk/xen.git vcpuset.v4

In short, these two patches were modified since v3 posting:

 [PATCH v4 2/7] libxl: In libxl_set_vcpuonline check for maximum
 [PATCH v4 7/7] libxl/vcpu-set - allow to decrease vcpu count on

while the rest is the same.

Thank you for taking the time to review these patches!

 tools/libxl/libxl.c         | 73 ++++++++++++++++++++++++++++-----------------
 tools/libxl/libxl.h         |  9 +++++-
 tools/libxl/libxl_types.idl |  1 +
 tools/libxl/xl_cmdimpl.c    | 47 ++++++++++++++++++-----------
 4 files changed, 84 insertions(+), 46 deletions(-)

Konrad Rzeszutek Wilk (7):
      libxl: Add ERROR_DOMAIN_NOTFOUND for libxl_domain_info when it cannot 
find the domain
      libxl: In libxl_set_vcpuonline check for maximum number of VCPUs against 
the cpumap.
      libxl/libxl_domain_info: Log if domain not found.
      libxl/vcpuset: Print error if libxl_set_vcpuonline returns 
ERROR_DOMAIN_NOTFOUND
      libxl/vcpuset: Return error value if failed.
      libxl/vcpuset: Remove useless limit on max_vcpus.
      libxl/vcpuset - allow to decrease vcpu count on overcommitted guests (v5)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.