Re: [Xen-devel] [PATCH 26/29] libxl: cancellation: Handle SIGTERM in save/restore helper

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote:
> During startup of the save/restore helper, set the disposition of
> SIGTERM appropriately.
> 
> For restore, we can simply die immediately - there is no point trying
> to do any kind of cleanup on what is now going to be a trashed domain.
> 
> For save, we want to arrange that libxc's cleanup code (eg turning off
> logdirty) takes place.  So our signal handler replaces the fd with one
> on which writes will fail, causing libxc's own loop to fail next time
> it actually tries to do a write.
> 
> Currently this has only a minor beneficial effect: we don't send the
> helper a SIGTERM ourselves, and if someone else contrives to send our
> helper a SIGTERM they have probably sent one to libxl too in which
> case things are going to be a bit messy anyway.
> 
> But in the next patch libxl is going to use SIGTERM itself on ao
> cancellation.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel