Re: [Xen-devel] [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-03-19 at 17:53 -0400, Boris Ostrovsky wrote:
[...]
> * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid 
> type
>   (core, socket, node).

But not for distance:

> @@ -1375,7 +1360,7 @@ static PyObject *pyxc_numainfo(XcObject *self)
>          for ( j = 0; j <= max_node_index; j++ )
>          {
>              uint32_t dist = nodes_dist[i*(max_node_index+1) + j];
> -            if ( dist == INVALID_TOPOLOGY_ID )
> +            if ( dist == ~0u )

?

Other than that the tools side here looks ok.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel