Re: [Xen-devel] [PATCH v3 3/7] vTPM: add TPM TCPA and SSDT for HVM virtual machine when vTPM is added

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-03-13 at 15:46 +0000, Wei Liu wrote:
> On Tue, Mar 10, 2015 at 08:13:58AM -0400, Quan Xu wrote:
> > Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> > ---
> >  tools/firmware/hvmloader/acpi/build.c | 7 ++++---
> >  tools/libxl/libxl_create.c            | 5 ++++-
> >  2 files changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tools/firmware/hvmloader/acpi/build.c 
> > b/tools/firmware/hvmloader/acpi/build.c
> > index 1431296..49f6772 100644
> > --- a/tools/firmware/hvmloader/acpi/build.c
> > +++ b/tools/firmware/hvmloader/acpi/build.c
> > @@ -313,9 +313,10 @@ static int construct_secondary_tables(unsigned long 
> > *table_ptrs,
> >  
> >      /* TPM TCPA and SSDT. */
> >      tis_hdr = (uint16_t *)0xFED40F00;
> > -    if ( (tis_hdr[0] == tis_signature[0]) &&
> > -         (tis_hdr[1] == tis_signature[1]) &&
> > -         (tis_hdr[2] == tis_signature[2]) )
> > +    if (((tis_hdr[0] == tis_signature[0]) &&
> > +        (tis_hdr[1] == tis_signature[1]) &&
> 
> These two lines are not necessary. They are not functional change and
> violate coding style.

Yes, this series so far has been full of this sort of thing. which is
rather obscuring what is going on.

I think I'll wait for a v4 with these issues fixed before I look at the
rest of it.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel