Re: [Xen-devel] [PATCH v2] libxl/libxl_qmp.c: fix qmp_open

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 19, 2015 at 06:40:30AM +0000, PRAMOD DEVENDRA wrote:
> From: Pramod Devendra <pramod.devendra@xxxxxxxxxx>
> 
> Signed-off-by: Pramod Devendra <pramod.devendra@xxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Changed since v1:
> 1. Make sure sun_path does not overflow.
> 2. Close qmp_fd on error.

These lines should be in the commit log itself. Putting them here makes
them get discarded when committing.

You also need to write about your third change, which was requested by
Ian. That is 

  3. Use "goto out" error handling idiom.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel