Re: [Xen-devel] [PATCH] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/13/2015 08:37 PM, Konrad Rzeszutek Wilk wrote:
> +static int parse_cpumask(const char *arg)
> +{
> +    xc_cpumap_t map;
> +    uint32_t v, i;
> +    int bits = 0;
> +
> +    map = malloc(sizeof(uint32_t));
> +    if ( !map )
> +        return -ENOMEM;
> +
> +    v = argtol(arg, 0);
> +    for ( i = 0; i < sizeof(uint32_t) ; i++ )
> +        map[i] = (v >> (i * 8)) & 0xff;
> +
> +    for ( i = 0; v; v >>= 1)
> +        bits += v & 1;

Uum, it looks like this is counting the 1-bits in v, not the total
number of bist.  So "0x8000" would finish with bits == 1 ; but we would
this to finish with bits == 16, don't we?

Or am I confused?

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel