Re: [Xen-devel] [PATCH 2/6] x86: add support for COS/CBM manangement

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Fri, Mar 13, 2015 at 09:53:37AM -0400, Konrad Rzeszutek Wilk wrote:
> > +    xfree(d->arch.psr_cos_ids);
> 
> And d->arch.psr_cos_ids = NULL
> 
> (however this depends on who calls psr_domain_init, which
> is unclear to me).
> 
> > +}
> > +
> > +int psr_domain_init(struct domain *d)
> > +{
> > +    if ( cat_socket_info )
> > +    {
> > +        d->arch.psr_cos_ids = xzalloc_array(unsigned int, opt_socket_num);
> > +        if ( !d->arch.psr_cos_ids )
> > +            return -ENOMEM;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +void psr_domain_free(struct domain *d)
> 
> So who calls this?

This function is called by arch_domain_destroy() or the failure path of
arch_domain_create(). In both cases the domain structure will be freed
later so setting NULL is pointless.

Thanks,
Chao
> 
> > +{
> > +    psr_free_rmid(d);
> > +    psr_free_cos(d);
> > +}
> > +

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel