Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Mar 13, Wei Liu wrote:

> On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote:
> > On Thu, Mar 12, Ian Campbell wrote:
> > 
> > > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote:
> > > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I
> > > > assume its required to validate input in libxl_device_vscsi_get_host.
> > > Not sure what you mean, you should call libxl_device_vcsci_init before
> > > using the object and then _dispose when you are done.
> > 
> > I mean NULL pointer checks, will do that for at least *vscsi_host.
> > 
> 
> That is only to make _dispose function NULL-tolerant. Why does that
> affect your implementation?

I have not checked other code pats in libxl, but does libxl expect valid
input? At least glibc for example expects valid input, str*(NULL) crashes.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel