Re: [Xen-devel] [PATCH V6 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl

[Tim Deegan <tim@xxxxxxx>]

At 01:11 +0100 on 18 Feb (1424218303), Tamas K Lengyel wrote:
> Thus far mem_access and mem_sharing memops had been able to signal
> to Xen to start pulling responses off the corresponding rings. In this patch
> we retire these memops and add them to the option to the vm_event_op domctl.
> 
> The vm_event_op domctl suboptions are the same for each ring thus we
> consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME.
> 
> As part of this patch in libxc we also rename the mem_access_enable/disable
> functions to monitor_enable/disable and move them into xc_monitor.c.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I think there's still an outstanding question about the repeated code
in vm_event.c, which could be unified -- last time you suggested maybe
just getting rid of the wakeup operation entirely.

Nevertheless I think this patch is good on its own.  So,

Acked-by: Tim Deegan <tim@xxxxxxx>

Cheers,

Tim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel