Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.03.15 at 15:36, <konrad.wilk@xxxxxxxxxx> wrote:
> @@ -504,10 +511,9 @@ void machine_restart(unsigned int delay_millisecs)
>          tboot_shutdown(TB_SHUTDOWN_REBOOT);
>      }
>  
> -    efi_reset_system(reboot_mode != 0);
> -
>      /* Rebooting needs to touch the page at absolute address 0. */
> -    *((unsigned short *)__va(0x472)) = reboot_mode;
> +    if ( !efi_enabled )
> +        *((unsigned short *)__va(0x472)) = reboot_mode;

This shouldn't depend on efi_enabled, but on reboot type not being
BOOT_EFI (which means it may need to be duplicated in the "case
BOOT_EFI:" code).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel